Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[item] don't match spider webs #1120

Merged
merged 2 commits into from
May 16, 2024
Merged

[item] don't match spider webs #1120

merged 2 commits into from
May 16, 2024

Conversation

myk002
Copy link
Member

@myk002 myk002 commented May 16, 2024

@chdoc FYI

@chdoc
Copy link
Member

chdoc commented May 16, 2024

I would argue that counting the number webs available for gathering, in particular when restricted to some burrow, is a perfectly valid use case for item. Thus, I would much prefer an option along the lines of -ignore-webs . (Yes, I actually think that the default should be to include them.)

@chdoc
Copy link
Member

chdoc commented May 16, 2024

Addendum: In fact, the more common use case is probably to forbid all items inside some cavern burrow or outside some burrow that designates the "safe area" of the fort. So yes, item definitely should include webs by default.

@myk002
Copy link
Member Author

myk002 commented May 16, 2024

that's fair; will change

@myk002 myk002 merged commit 59e5245 into DFHack:master May 16, 2024
10 checks passed
@myk002 myk002 deleted the myk_item branch May 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants